linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky)
Subject: [PATCH 15/15] block: Add FIXME comment to handle device_add_disk error
Date: Thu, 18 Aug 2016 11:36:33 +0900	[thread overview]
Message-ID: <20160818023633.GC500@swordfish> (raw)
In-Reply-To: <1471418115-3654-16-git-send-email-famz@redhat.com>

On (08/17/16 15:15), Fam Zheng wrote:
[..]
>   (
>     rc = device_add_disk(e1, e2, e3);
>   |
>   + /* FIXME: handle error. */
>     device_add_disk(e1, e2, e3);

or use __must_check for device_add_disk() function?
/* which is _attribute__((warn_unused_result)) */

	-ss

      reply	other threads:[~2016-08-18  2:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  7:15 [PATCH 00/15] Fix issue with KOBJ_ADD uevent versus disk attributes Fam Zheng
2016-08-17  7:15 ` [PATCH 01/15] disk: Drop add_disk in favor of device_add_disk Fam Zheng
2016-08-17  7:15 ` [PATCH 02/15] genhd: Return error from register_disk() Fam Zheng
2016-08-17  7:15 ` [PATCH 03/15] genhd: Return error from blk_register_region Fam Zheng
2016-08-17  7:15 ` [PATCH 04/15] block: Return error from blk_integrity_add Fam Zheng
2016-08-17  7:15 ` [PATCH 05/15] genhd: Return error from disk_{add,alloc}_events Fam Zheng
2016-08-17  7:15 ` [PATCH 06/15] genhd: Add return code to device_add_disk Fam Zheng
2016-08-17  8:49   ` Cornelia Huck
2016-08-17  8:48     ` Fam Zheng
2016-08-17  9:06       ` Cornelia Huck
2016-08-17  9:14         ` Fam Zheng
2016-08-18  1:09           ` Ed Cashin
2016-08-17  7:15 ` [PATCH 07/15] genhd: Add attribute group parameter " Fam Zheng
2016-08-17  7:15 ` [PATCH 08/15] nvme: Pass attribute group " Fam Zheng
2016-08-17  8:13   ` kbuild test robot
2016-08-17  7:15 ` [PATCH 09/15] virtio-blk: " Fam Zheng
2016-09-04  4:18   ` Michael S. Tsirkin
2016-08-17  7:15 ` [PATCH 10/15] mtd: " Fam Zheng
2016-08-17  7:15 ` [PATCH 11/15] zram: " Fam Zheng
2016-08-18  1:59   ` Sergey Senozhatsky
2016-08-18  2:06     ` Sergey Senozhatsky
2016-08-17  7:15 ` [PATCH 12/15] mtip: " Fam Zheng
2016-08-17  7:15 ` [PATCH 13/15] aoeblk: " Fam Zheng
2016-08-17  7:15 ` [PATCH 14/15] axonram: " Fam Zheng
2016-08-17  7:15 ` [PATCH 15/15] block: Add FIXME comment to handle device_add_disk error Fam Zheng
2016-08-18  2:36   ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160818023633.GC500@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).