linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: NVME PCI driver question
Date: Tue, 23 Aug 2016 10:41:57 -0400	[thread overview]
Message-ID: <20160823144157.GF28276@localhost.localdomain> (raw)
In-Reply-To: <0aa9297eed8d4090a5e24c611e47d7c7@CWMAIL-AP-F14.dji.com>

On Tue, Aug 23, 2016@09:03:07AM +0000, First Light wrote:
> Dear maintainers of NVME driver
> I have a question about NVME driver.
> In drivers/nvme/host/pci.c, function: nvme_dev_map calls pci_enable_msix, what if  a device just supports MSI but doesn't support MSIX? in such logic, if   pci_enable_msix failed,

It sounds like you're not using the most recent version of the driver.

The function you're referring sets up early initialisation and would
use MSI-x if INTx was not available. This version of the driver would
also poll for completions if INTx wasn't working.

The nvme_setup_io_queues function would redo all the interrupt setup
once the driver knew how many vectors it needed to allocate. This
routine would fallback to MSI if MSI-x was not supported, so you should
be fine.

> I'm using synopsys pcie driver which doesn't support MSIX, but I also want to use it to connect a SSD, what should I do to make it work?

I assume you mean synopsys pcie "drive" rather than driver. It should
work just fine.

      reply	other threads:[~2016-08-23 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  9:03 NVME PCI driver question First Light
2016-08-23 14:41 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823144157.GF28276@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).