NVME PCI driver question

NVME PCI driver question

[First Light]

Dear maintainers of NVME driver
I have a question about NVME driver.
In drivers/nvme/host/pci.c, function: nvme_dev_map calls pci_enable_msix, what if  a device just supports MSI but doesn't support MSIX? in such logic, if   pci_enable_msix failed,
I'm using synopsys pcie driver which doesn't support MSIX, but I also want to use it to connect a SSD, what should I do to make it work?

Thanks
Xiaoguang





This email and any attachments thereto may contain private, confidential, and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments thereto) by others is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.

???????????????????????????????? ???????????????????????????????????????????????????????????????????????

NVME PCI driver question

[Keith Busch]

On Tue, Aug 23, 2016@09:03:07AM +0000, First Light wrote:
> Dear maintainers of NVME driver
> I have a question about NVME driver.
> In drivers/nvme/host/pci.c, function: nvme_dev_map calls pci_enable_msix, what if  a device just supports MSI but doesn't support MSIX? in such logic, if   pci_enable_msix failed,

It sounds like you're not using the most recent version of the driver.

The function you're referring sets up early initialisation and would
use MSI-x if INTx was not available. This version of the driver would
also poll for completions if INTx wasn't working.

The nvme_setup_io_queues function would redo all the interrupt setup
once the driver knew how many vectors it needed to allocate. This
routine would fallback to MSI if MSI-x was not supported, so you should
be fine.

> I'm using synopsys pcie driver which doesn't support MSIX, but I also want to use it to connect a SSD, what should I do to make it work?

I assume you mean synopsys pcie "drive" rather than driver. It should
work just fine.