From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH WIP/RFC 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure
Date: Fri, 26 Aug 2016 16:39:52 +0200 [thread overview]
Message-ID: <20160826143952.GB21869@lst.de> (raw)
In-Reply-To: <9f6479110ae58e72e78e37855aff3f8edb8a61e9.1472219586.git.swise@opengridcomputing.com>
On Fri, Aug 26, 2016@06:50:58AM -0700, Steve Wise wrote:
> After address resolution, the nvme_rdma_queue rdma resources are
> allocated. If rdma route resolution or the connect fails, or the
> controller reconnect times out and gives up, then the rdma resources
> need to be freed. Otherwise, rdma resources are leaked.
I'm pretty sure Sagi tried to convince me we'd need something like this
begfore and I tried to resists. Sorry guys..
> struct nvme_rdma_queue {
> @@ -488,6 +489,7 @@ static void nvme_rdma_destroy_queue_ib(struct nvme_rdma_queue *queue)
> struct nvme_rdma_device *dev = queue->device;
> struct ib_device *ibdev = dev->dev;
>
> + clear_bit(NVME_RDMA_IB_QUEUE_ALLOCATED, &queue->flags);
How about doing a
if (!test_and_clear(NVME_RDMA_IB_QUEUE_ALLOCATED, &queue->flags))
return;
here so the the callers don't have to worry?
Otherwise this looks fine to me.
next prev parent reply other threads:[~2016-08-26 14:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 13:53 [PATCH WIP/RFC 0/6] nvme-rdma device removal fixes Steve Wise
2016-08-25 20:49 ` [PATCH WIP/RFC 1/6] iw_cxgb4: call dev_put() on l2t allocation failure Steve Wise
2016-08-28 12:42 ` Sagi Grimberg
2016-08-26 13:50 ` [PATCH WIP/RFC 2/6] iw_cxgb4: block module unload until all ep resources are released Steve Wise
2016-08-28 12:43 ` Sagi Grimberg
2016-08-26 13:50 ` [PATCH WIP/RFC 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush Steve Wise
2016-08-26 14:38 ` Christoph Hellwig
2016-08-26 14:41 ` Steve Wise
2016-08-28 12:45 ` Sagi Grimberg
2016-08-26 13:50 ` [PATCH WIP/RFC 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure Steve Wise
2016-08-26 14:39 ` Christoph Hellwig [this message]
2016-08-26 14:42 ` Steve Wise
2016-08-28 12:44 ` Sagi Grimberg
2016-08-26 13:50 ` [PATCH WIP/RFC 5/6] nvme-rdma: add DELETING queue flag Steve Wise
2016-08-26 14:14 ` Steve Wise
2016-08-28 12:48 ` Sagi Grimberg
2016-08-26 13:52 ` [PATCH WIP/RFC 6/6] nvme-rdma: keep a cm_id around during reconnect to get events Steve Wise
2016-08-26 14:41 ` Christoph Hellwig
2016-08-26 14:48 ` Steve Wise
2016-08-28 12:56 ` Sagi Grimberg
2016-08-29 7:30 ` Christoph Hellwig
2016-08-29 14:32 ` Sagi Grimberg
2016-08-29 19:42 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826143952.GB21869@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).