From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
Date: Tue, 30 Aug 2016 08:36:51 +0200 [thread overview]
Message-ID: <20160830063651.GA32323@lst.de> (raw)
In-Reply-To: <CALCETrWzfovS+kh=UsJZxNvN-_eypav+Df+NppPHt8FPPOSipw@mail.gmail.com>
On Mon, Aug 29, 2016@04:20:43PM -0700, Andy Lutomirski wrote:
> The "Set Features" command (section 5.15) Figure 103 says:
>
> If using PRPs, this field shall not be a pointer to a PRP List as the
> data buffer may not cross more than one page boundary. If no data
> structure is used as part of the specified feature, then this field is
> not used.
>
> Does the Linux driver use PRPs?
The Linux PCIe driver always uses PRPs - and for admin command only
Fabrics can use SGLs anyway.
> Do we need to worry about kmalloc
> returning a buffer that spans a 4k boundary but does not span a Linux
> page boundary?
Isn't kmalloc supposed to return naturally aligned buffers?
next prev parent reply other threads:[~2016-08-30 6:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 9:25 [PATCH 0/3] nvme power saving Andy Lutomirski
2016-08-29 9:25 ` [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-08-29 9:25 ` [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-08-29 16:27 ` Keith Busch
2016-08-29 23:20 ` Andy Lutomirski
2016-08-30 6:36 ` Christoph Hellwig [this message]
2016-08-30 16:00 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-08-29 15:07 ` J Freyensee
2016-08-29 23:16 ` Andy Lutomirski
2016-08-30 20:21 ` Andy Lutomirski
2016-09-02 18:11 ` J Freyensee
2016-09-02 18:50 ` Andy Lutomirski
2016-08-29 16:45 ` Keith Busch
2016-08-29 23:16 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830063651.GA32323@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).