linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH WIP/RFC v3 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush
Date: Thu, 1 Sep 2016 10:36:09 +0200	[thread overview]
Message-ID: <20160901083609.GC3703@lst.de> (raw)
In-Reply-To: <c749145e-618e-ef0c-4249-8f441c55e4b1@grimberg.me>

On Tue, Aug 30, 2016@08:24:50PM +0300, Sagi Grimberg wrote:
>
>> -	/* Queue controller deletion */
>> +	/*
>> +	 * Queue controller deletion. Keep a reference until all
>> +	 * work is flushed since delete_work will free the ctrl mem
>> +	 */
>> +	kref_get(&ctrl->ctrl.kref);
>
> kref_get_unless_zero?

How could the refcount be zero here?

  parent reply	other threads:[~2016-09-01  8:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 16:26 [PATCH WIP/RFC v3 0/6] nvme-rdma device removal fixes Steve Wise
2016-08-29 21:26 ` [PATCH WIP/RFC v3 1/6] iw_cxgb4: call dev_put() on l2t allocation failure Steve Wise
2016-09-01  8:34   ` Christoph Hellwig
2016-08-29 21:26 ` [PATCH WIP/RFC v3 2/6] iw_cxgb4: block module unload until all ep resources are released Steve Wise
2016-09-01  8:35   ` Christoph Hellwig
2016-08-29 21:27 ` [PATCH WIP/RFC v3 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush Steve Wise
2016-08-30 17:24   ` Sagi Grimberg
2016-08-30 17:48     ` Steve Wise
2016-08-31  5:06       ` Sagi Grimberg
2016-08-31 14:29         ` Steve Wise
2016-09-01  6:40           ` Sagi Grimberg
2016-09-01  8:36     ` Christoph Hellwig [this message]
2016-09-01  9:31       ` Sagi Grimberg
2016-08-29 21:28 ` [PATCH WIP/RFC v3 5/6] nvme-rdma: add DELETING queue flag Sagi Grimberg
2016-09-01  8:41   ` Christoph Hellwig
2016-09-01 13:34     ` Steve Wise
2016-08-29 21:28 ` [PATCH WIP/RFC v3 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure Steve Wise
2016-09-01 15:00   ` Steve Wise
2016-08-30 16:25 ` [PATCH WIP/RFC v3 6/6] nvme-rdma: use ib_client API to detect device removal Steve Wise
2016-09-01  8:36   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160901083609.GC3703@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).