From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 1 Sep 2016 10:41:01 +0200 Subject: [PATCH WIP/RFC v3 5/6] nvme-rdma: add DELETING queue flag In-Reply-To: <0893620168fb1fd904fa1ff8b4893ffdb44214e8.1472574410.git.swise@opengridcomputing.com> References: <0893620168fb1fd904fa1ff8b4893ffdb44214e8.1472574410.git.swise@opengridcomputing.com> Message-ID: <20160901084101.GE3703@lst.de> Steve, this mail pretends to be from Sagi, which given the threading looks unlikely. Can you fix up your patch mail scripts so that it appears from you and has another From: Sagi Grimberg line in the mail body? > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > index c2f6cc6..8036c23 100644 > --- a/drivers/nvme/host/rdma.c > +++ b/drivers/nvme/host/rdma.c > @@ -88,6 +88,7 @@ struct nvme_rdma_request { > enum nvme_rdma_queue_flags { > NVME_RDMA_Q_CONNECTED = (1 << 0), > NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1), > + NVME_RDMA_Q_DELETING = (1 << 2), Can we please aligned these now that we have a few? NVME_RDMA_Q_CONNECTED = (1 << 0), NVME_RDMA_IB_QUEUE_ALLOCATED = (1 << 1), NVME_RDMA_Q_DELETING = (1 << 2), Otherwise this looks fine: Reviewed-by: Christoph Hellwig