linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-rdma: Fix early queue flags settings
Date: Tue, 20 Sep 2016 22:08:03 +0200	[thread overview]
Message-ID: <20160920200803.GA839@lst.de> (raw)
In-Reply-To: <1474397848-19013-1-git-send-email-sagi@grimberg.me>

On Tue, Sep 20, 2016@11:57:28AM -0700, Sagi Grimberg wrote:
> When we reconnect we can't really clear the
> queue flags (DELETING flag in specific) because
> we might end up trigerring a use-after-free condition
> if we fail to establish the rdma connection.

Can you add a comment explaining this to the assignment?  Looking
at the patch it looks like black magic to be, and that's even
after reading the above changelog..

  parent reply	other threads:[~2016-09-20 20:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 18:57 [PATCH] nvme-rdma: Fix early queue flags settings Sagi Grimberg
2016-09-20 19:01 ` Steve Wise
2016-09-20 19:05   ` Sagi Grimberg
2016-09-20 20:08 ` Christoph Hellwig [this message]
2016-09-20 20:14   ` Steve Wise
2016-09-21  3:38     ` Sagi Grimberg
2016-09-21 14:01       ` 'Christoph Hellwig'
2016-09-21 14:18         ` Steve Wise
2016-09-21 14:52           ` Steve Wise
2016-09-21 15:10             ` Steve Wise
2016-09-21 14:36         ` Sagi Grimberg
2016-09-21 15:50           ` Steve Wise
2016-09-21 19:57             ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920200803.GA839@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).