From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme-cli/fabrics: Add keep-alive-tmo param to connect cmd
Date: Thu, 22 Sep 2016 12:46:20 -0400 [thread overview]
Message-ID: <20160922164620.GB14301@keith> (raw)
In-Reply-To: <1474408553.8869.23.camel@linux.intel.com>
On Tue, Sep 20, 2016@02:55:53PM -0700, J Freyensee wrote:
> On Tue, 2016-09-20@08:01 -0700, Steve Wise wrote:
> > Added 'keep-alive-tmo' to 'connect' command so users can specify the
> > keep alive timeout period.
> >
> > usage examples:
> >
> > nvme connect --keep-alive-tmo=30 --transport=rdma --traddr=10.0.1.14
> > --nqn=test-nvme
> > nvme connect -k 30 -t rdma -a 10.0.1.14 -n test-nvme
> >
> > Signed-off-by: Steve Wise <swise at opengridcomputing.com>
> >?
>
> Looks good to me,
> Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
Thanks, I've applied both patches in this series. I had to slightly
modify the patches to apply on the master branch due to some code
formatting changes.
Now that I look at it, I actually think the code format was nicer before
the cleanups, but that's okay. :)
prev parent reply other threads:[~2016-09-22 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:01 [PATCH 1/2] nvme-cli/fabrics: Add keep-alive-tmo param to connect cmd Steve Wise
2016-09-20 21:55 ` J Freyensee
2016-09-22 16:46 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922164620.GB14301@keith \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).