From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme: Delete created IO queues on reset
Date: Thu, 6 Oct 2016 11:23:37 -0400 [thread overview]
Message-ID: <20161006152337.GA1778@localhost.localdomain> (raw)
In-Reply-To: <20161006093252.GA4999@lst.de>
On Thu, Oct 06, 2016@11:32:52AM +0200, Christoph Hellwig wrote:
> On Wed, Oct 05, 2016@04:32:46PM -0400, Keith Busch wrote:
> > Commit c21377f8 (Suspend all queues before deletion) decrements the
> > online queue count prior to our attempt to delete those IO queues, so
> > the driver ended up not having the controller delete any. This patch
> > uses the queue_count instead of online_queues.
>
> What if not all queues were online before? Should we take a
> a snapshot of ->online_queues before suspending the queues and
> then use that later?
That sounds good. In the worst case, using queue_count may attempt to
delete a queue the adapter didn't create, which just returns an invalid
QID error, and everything continues as normal. But it's easily
avoidable, so I'll send a v2 of this one.
next prev parent reply other threads:[~2016-10-06 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 20:32 [PATCH 1/2] nvme: don't schedule multiple resets Keith Busch
2016-10-05 20:32 ` [PATCH 2/2] nvme: Delete created IO queues on reset Keith Busch
2016-10-05 22:58 ` Sagi Grimberg
2016-10-06 1:47 ` Gabriel Krisman Bertazi
2016-10-06 9:32 ` Christoph Hellwig
2016-10-06 15:23 ` Keith Busch [this message]
2016-10-05 22:57 ` [PATCH 1/2] nvme: don't schedule multiple resets Sagi Grimberg
2016-10-06 9:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006152337.GA1778@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox