From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 5/6] nvme-fabrics: Print network address if address resolution fails
Date: Wed, 19 Oct 2016 12:39:39 +0200 [thread overview]
Message-ID: <20161019103939.GC1191@lst.de> (raw)
In-Reply-To: <020cf76d-b63e-af62-07d0-c41ff51277ec@sandisk.com>
On Tue, Oct 18, 2016@01:11:28PM -0700, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
> ---
> drivers/nvme/host/rdma.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 5a83881..9612ea0 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -568,14 +568,16 @@ static int nvme_rdma_init_queue(struct nvme_rdma_ctrl *ctrl,
> NVME_RDMA_CONNECT_TIMEOUT_MS);
> if (ret) {
> dev_info(ctrl->ctrl.device,
> - "rdma_resolve_addr failed (%d).\n", ret);
> + "rdma_resolve_addr(%pISpc) failed (%d).\n",
> + &ctrl->addr, ret);
> goto out_destroy_cm_id;
> }
>
> ret = nvme_rdma_wait_for_cm(queue);
> if (ret) {
> dev_info(ctrl->ctrl.device,
> - "rdma_resolve_addr wait failed (%d).\n", ret);
> + "rdma_resolve_addr(%pISpc) wait failed (%d).\n",
> + &ctrl->addr, ret);
Can you skip the indentation change? Also once have the address how
about:
"Failed to resolve %pISpc (instant), error %d).\n"
"Failed to resolve %pISpc (wait), error %d.\n"
next prev parent reply other threads:[~2016-10-19 10:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 20:09 [PATCH 0/6] Six NVMeOF-related patches Bart Van Assche
2016-10-18 20:10 ` [PATCH 1/6] nvme/scsi: Remove set-but-not-used variables Bart Van Assche
2016-10-19 7:26 ` Johannes Thumshirn
2016-10-19 10:31 ` Christoph Hellwig
2016-10-18 20:10 ` [PATCH 2/6] nvme-fabrics: Adjust source code indentation Bart Van Assche
2016-10-19 7:26 ` Johannes Thumshirn
2016-10-19 10:31 ` Christoph Hellwig
2016-10-18 20:10 ` [PATCH 3/6] nvme-fabrics: Fix memory leaks in nvmf_parse_options() Bart Van Assche
2016-10-19 7:27 ` Johannes Thumshirn
2016-10-19 10:37 ` Christoph Hellwig
2016-10-18 20:11 ` [PATCH 4/6] nvme-fabrics: Fix a memory leak in an nvmf_create_ctrl() error path Bart Van Assche
2016-10-19 7:27 ` Johannes Thumshirn
2016-10-19 10:37 ` Christoph Hellwig
2016-10-18 20:11 ` [PATCH 5/6] nvme-fabrics: Print network address if address resolution fails Bart Van Assche
2016-10-19 7:27 ` Johannes Thumshirn
2016-10-19 10:39 ` Christoph Hellwig [this message]
2016-10-19 17:02 ` Bart Van Assche
2016-10-20 7:54 ` Sagi Grimberg
2016-10-18 20:12 ` [PATCH 6/6] nvme/rdma: Make nvme_rdma_conn_rejected() more informative Bart Van Assche
2016-10-19 7:29 ` Johannes Thumshirn
2016-10-19 10:41 ` Christoph Hellwig
2016-10-19 17:08 ` Bart Van Assche
2016-10-20 7:57 ` Sagi Grimberg
2016-10-20 14:35 ` Steve Wise
2016-10-20 17:34 ` Bart Van Assche
2016-10-20 17:45 ` Steve Wise
2016-10-20 18:05 ` Bart Van Assche
2016-10-20 18:11 ` Steve Wise
[not found] ` <012601d22afd$5a310460$0e930d20$@opengridcomputing.com>
2016-10-20 19:51 ` Steve Wise
[not found] ` <015201d22b0b$4f526440$edf72cc0$@opengridcomputing.com>
2016-10-20 20:41 ` Steve Wise
2016-10-20 21:08 ` Bart Van Assche
2016-10-20 21:12 ` Steve Wise
[not found] ` <018701d22b16$b4927e20$1db77a60$@opengridcomputing.com>
2016-10-20 21:35 ` Steve Wise
2016-10-18 22:16 ` [PATCH 0/6] Six NVMeOF-related patches Keith Busch
2016-10-20 8:02 ` Sagi Grimberg
2016-10-20 17:38 ` Bart Van Assche
2016-10-21 13:32 ` Christoph Hellwig
2016-10-21 15:08 ` Keith Busch
2016-10-21 21:33 ` Sagi Grimberg
2016-10-25 16:48 ` Sagi Grimberg
2016-10-25 16:55 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019103939.GC1191@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).