From: hch@lst.de (Christoph Hellwig)
Subject: Disconnecting nvmet-rdma
Date: Wed, 19 Oct 2016 15:00:09 +0200 [thread overview]
Message-ID: <20161019130009.GA5876@lst.de> (raw)
In-Reply-To: <26c343fe-23a8-e482-0b28-0b4a8c2ac70e@sandisk.com>
On Tue, Oct 18, 2016@03:02:03PM -0700, Bart Van Assche wrote:
> Hello Christoph,
>
> Without the patch below I can easily trigger a NULL pointer dereference in
> nvmet_rdma_queue_disconnect(). However, I don't think that that patch is
> correct. Can you have a look at this?
Hi Bart,
how do you reproduce the timedwait condition? My RDMA test setup is
still being moved, so I can't reproduce it myself, but I'd like to know
for the future.
The only reason why I could see a NULL queue here is if RDMA/CM
also calls the timedwait exit handler for the listener CM ids,
in which case your patch would be correct. Can you check for that
theory by printing the cm_id address in nvmet_rdma_add_port and in
nvmet_rdma_cm_handler?
Also is there any chance you could try your reproducer with the iSER target
as well? It also seems to blindly derference the queue.
next prev parent reply other threads:[~2016-10-19 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 22:02 Disconnecting nvmet-rdma Bart Van Assche
2016-10-19 13:00 ` Christoph Hellwig [this message]
2016-10-20 7:49 ` Sagi Grimberg
2016-10-21 13:39 ` Christoph Hellwig
2016-10-21 15:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019130009.GA5876@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox