From: hch@lst.de ('Christoph Hellwig')
Subject: [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects
Date: Mon, 24 Oct 2016 17:09:12 +0200 [thread overview]
Message-ID: <20161024150912.GA6866@lst.de> (raw)
In-Reply-To: <011d01d22e06$fd606480$f8212d80$@opengridcomputing.com>
On Mon, Oct 24, 2016@09:57:50AM -0500, Steve Wise wrote:
> > rdma_reject_msg() - protocol reject reason string
This one sounds useful on it's own.
> > rdma_is_consumer_reject() - true if the peer consumer/ulp rejected
> > rdma_consumer_reject_data() - ptr to any private data
I see why these are conceptually different, but why do we care
if something is a consumer reject except for printing what reject
we got (solved by rdma_reject_msg) or for getting consumer reject
data if there is any (solved by rdma_consumer_reject_data).
So all three helpers are fine with me, but rdma_is_consumer_reject
would be more of a low-level helper that drivers wouldn't use
directly, only through rdma_consumer_reject_data.
next prev parent reply other threads:[~2016-10-24 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 22:40 [PATCH RFC v2 0/3] connect reject event helpers Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 1/3] rdma_cm: add rdma_reject_msg() helper function Steve Wise
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 14:07 ` Steve Wise
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-20 22:40 ` [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() " Steve Wise
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 14:09 ` Steve Wise
2016-10-21 15:50 ` Parav Pandit
2016-10-21 21:45 ` Sagi Grimberg
2016-10-22 15:57 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects Steve Wise
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 21:48 ` Sagi Grimberg
2016-10-22 16:12 ` Steve Wise
[not found] ` <005701d22c7f$0c883ed0$2598bc70$@opengridcomputing.com>
2016-10-24 14:57 ` Steve Wise
2016-10-24 15:09 ` 'Christoph Hellwig' [this message]
2016-10-21 21:53 ` [PATCH RFC v2 0/3] connect reject event helpers Sagi Grimberg
2016-10-21 21:58 ` Steve Wise
[not found] ` <001701d22be6$4854b8b0$d8fe2a10$@opengridcomputing.com>
2016-10-24 17:44 ` Steve Wise
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:57 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024150912.GA6866@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).