From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 01/12] blk-mq: Do not invoke .queue_rq() for a stopped queue
Date: Thu, 27 Oct 2016 10:14:37 +0200 [thread overview]
Message-ID: <20161027081437.oasmbdo2se7smrb6@linux-x5ow.site> (raw)
In-Reply-To: <1debcf7f-c950-308b-d297-3e48a77e08d7@sandisk.com>
On Wed, Oct 26, 2016@03:50:44PM -0700, Bart Van Assche wrote:
> The meaning of the BLK_MQ_S_STOPPED flag is "do not call
> .queue_rq()". Hence modify blk_mq_make_request() such that requests
> are queued instead of issued if a queue has been stopped.
>
> Reported-by: Ming Lei <tom.leiming at gmail.com>
> Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-10-27 8:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 22:49 [PATCH v4 0/12] Fix race conditions related to stopping block layer queues Bart Van Assche
2016-10-26 22:50 ` [PATCH 01/12] blk-mq: Do not invoke .queue_rq() for a stopped queue Bart Van Assche
2016-10-27 5:47 ` Hannes Reinecke
2016-10-27 8:14 ` Johannes Thumshirn [this message]
2016-10-27 12:14 ` Sagi Grimberg
2016-10-26 22:51 ` [PATCH 02/12] blk-mq: Introduce blk_mq_hctx_stopped() Bart Van Assche
2016-10-27 1:33 ` Ming Lei
2016-10-27 5:48 ` Hannes Reinecke
2016-10-27 8:15 ` Johannes Thumshirn
2016-10-27 12:15 ` Sagi Grimberg
2016-10-27 12:40 ` Christoph Hellwig
2016-10-26 22:52 ` [PATCH 03/12] blk-mq: Introduce blk_mq_queue_stopped() Bart Van Assche
2016-10-27 5:49 ` Hannes Reinecke
2016-10-27 8:16 ` Johannes Thumshirn
2016-10-26 22:52 ` [PATCH 04/12] blk-mq: Move more code into blk_mq_direct_issue_request() Bart Van Assche
2016-10-27 5:50 ` Hannes Reinecke
2016-10-27 8:17 ` Johannes Thumshirn
2016-10-27 8:18 ` Johannes Thumshirn
2016-10-27 12:16 ` Sagi Grimberg
2016-10-27 12:40 ` Christoph Hellwig
2016-10-26 22:53 ` [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue() Bart Van Assche
2016-10-27 1:30 ` Ming Lei
2016-10-27 2:04 ` Bart Van Assche
2016-10-27 2:31 ` Ming Lei
2016-10-27 2:40 ` Bart Van Assche
2016-10-27 2:48 ` Ming Lei
2016-10-27 3:05 ` Bart Van Assche
2016-10-27 12:42 ` Christoph Hellwig
2016-10-27 13:16 ` Ming Lei
2016-10-27 5:52 ` Hannes Reinecke
2016-10-27 15:56 ` Bart Van Assche
2016-10-27 12:41 ` Christoph Hellwig
2016-10-26 22:53 ` [PATCH 06/12] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request() Bart Van Assche
2016-10-27 7:26 ` Hannes Reinecke
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 12:44 ` Christoph Hellwig
2016-10-26 22:54 ` [PATCH 07/12] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-27 7:27 ` Hannes Reinecke
2016-10-27 8:28 ` Johannes Thumshirn
2016-10-27 14:01 ` Mike Snitzer
2016-10-26 22:54 ` [PATCH 08/12] dm: Fix a race condition related to stopping and starting queues Bart Van Assche
2016-10-27 14:01 ` Mike Snitzer
2016-10-26 22:55 ` [PATCH 09/12] SRP transport: Move queuecommand() wait code to SCSI core Bart Van Assche
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 12:20 ` Sagi Grimberg
2016-10-26 22:55 ` [PATCH 10/12] SRP transport, scsi-mq: Wait for .queue_rq() if necessary Bart Van Assche
2016-10-27 8:27 ` Johannes Thumshirn
2016-10-27 12:19 ` Sagi Grimberg
2016-10-26 22:56 ` [PATCH 11/12] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-27 12:19 ` Sagi Grimberg
2016-10-28 16:01 ` Keith Busch
2016-10-28 18:51 ` Bart Van Assche
2016-10-28 21:06 ` Keith Busch
2016-10-26 22:56 ` [PATCH 12/12] nvme: Fix a race condition related to stopping queues Bart Van Assche
2016-10-26 23:28 ` [PATCH v4 0/12] Fix race conditions related to stopping block layer queues Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027081437.oasmbdo2se7smrb6@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).