From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v1] nvmet: Don't queue fatal error work if csts.cfs is set
Date: Sun, 6 Nov 2016 17:41:40 +0100 [thread overview]
Message-ID: <20161106164140.GG15675@lst.de> (raw)
In-Reply-To: <1478423778-29829-1-git-send-email-sagi@grimberg.me>
On Sun, Nov 06, 2016@11:16:18AM +0200, Sagi Grimberg wrote:
> In the transport, in case of an interal queue error like
> error completion in rdma we trigger a fatal error. However,
> multiple queues in the same controller can serr error completions
> and we don't want to trigger fatal error work more than once.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Looks fine, although I'd avoid the goto and just use a if blocks
for the rest of the action..
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2016-11-06 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 9:16 [PATCH v1] nvmet: Don't queue fatal error work if csts.cfs is set Sagi Grimberg
2016-11-06 16:41 ` Christoph Hellwig [this message]
2016-11-07 18:07 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161106164140.GG15675@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox