From: keith.busch@intel.com (Keith Busch)
Subject: Introducing Unit test framework based on nvme-cli
Date: Wed, 16 Nov 2016 13:35:23 -0500 [thread overview]
Message-ID: <20161116183522.GB10050@localhost.localdomain> (raw)
In-Reply-To: <20161116175828.GA1207@infradead.org>
On Wed, Nov 16, 2016@09:58:28AM -0800, Christoph Hellwig wrote:
> Stephen, Keith:
>
> any comments on this test suite? I'd really like to see this going
> somewhere, as it would make my life a lot easier.
This is awesome. Just a few comments on the documenation.
If we can get the README to list all the dependencies to run, it'd
make it easier on people like me who start with pretty bare-bones Linux
installations. Getting the environment ready required I run:
$ pip install nose nose2 pep8 flake8
The README also references a 'doc' folder, but it appears to be missing
from the commit.
Otherwise, I like this alot. I can apply it immediately if there's no
objection, and we can add more documentation as follow on commits.
next prev parent reply other threads:[~2016-11-16 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 6:48 Introducing Unit test framework based on nvme-cli Chaitanya Kulkarni
2016-10-27 6:48 ` [PATCH] Unittest " Chaitanya Kulkarni
2016-11-16 17:58 ` Introducing Unit test " Christoph Hellwig
2016-11-16 18:35 ` Keith Busch [this message]
2016-11-16 19:43 ` J Freyensee
2016-11-16 21:37 ` Keith Busch
2016-11-17 12:36 ` Sagi Grimberg
2016-11-17 12:40 ` Christoph Hellwig
2016-11-17 16:05 ` Keith Busch
2016-11-22 2:45 ` Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116183522.GB10050@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).