linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 2/2] nvme-rdma: align to generic ib_event logging helper
Date: Mon, 21 Nov 2016 23:41:31 -0800	[thread overview]
Message-ID: <20161122074131.GB5497@infradead.org> (raw)
In-Reply-To: <1479761145-13264-2-git-send-email-maxg@mellanox.com>

On Mon, Nov 21, 2016@10:45:45PM +0200, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
>  drivers/nvme/host/rdma.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 3d25add..bad4ce1 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
>  
>  static void nvme_rdma_qp_event(struct ib_event *event, void *context)
>  {
> -	pr_debug("QP event %d\n", event->event);
> +	pr_err("QP event %s (%d)\n",
> +	       ib_event_msg(event->event), event->event);
> +
>  }

Why not keep the pr_debug?

  reply	other threads:[~2016-11-22  7:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 20:45 [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper Max Gurtovoy
2016-11-21 20:45 ` [PATCH 2/2] nvme-rdma: " Max Gurtovoy
2016-11-22  7:41   ` Christoph Hellwig [this message]
2016-11-22  7:41 ` [PATCH 1/2] nvmet-rdma: " Christoph Hellwig
2016-11-22 14:00   ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122074131.GB5497@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).