From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings
Date: Mon, 28 Nov 2016 09:28:19 +0100 [thread overview]
Message-ID: <20161128082819.GA31105@lst.de> (raw)
In-Reply-To: <3504c280-fe7f-9ec2-0f92-2b6aea290080@samsung.com>
On Wed, Nov 23, 2016@09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.
Please send a patch to change it.
prev parent reply other threads:[~2016-11-28 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201509170828.xv0cYNA5%fengguang.wu@intel.com>
[not found] ` <alpine.DEB.2.10.1509171056470.2399@hadrien>
[not found] ` <55FAA16C.5070601@samsung.com>
[not found] ` <CGME20161122172658epcas4p43c58fc9861747068b50cc7af9337f692@epcas4p4.samsung.com>
[not found] ` <2122146.rzc0RNY0pB@avalon>
2016-11-23 8:35 ` [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings Andrzej Pietrasiewicz
2016-11-28 8:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128082819.GA31105@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).