From: scott.bauer@intel.com (Scott Bauer)
Subject: [PATCH v2 2/4] block: Add Sed-opal library
Date: Wed, 30 Nov 2016 11:09:42 -0700 [thread overview]
Message-ID: <20161130180941.GA23789@sbauer-Z170X-UD5> (raw)
In-Reply-To: <20161130181357.GD21081@localhost.localdomain>
es1;4205;0cOn Wed, Nov 30, 2016@01:13:57PM -0500, Keith Busch wrote:
> On Tue, Nov 29, 2016@02:52:00PM -0700, Scott Bauer wrote:
> > + dev = get_or_create_opal_dev(bdev, key->opal_act.key.lr, true);
> > + if (!dev)
> > + return -ENOMEM;
>
> The alloc_opal_dev from this call returns ERR_PTR values on error, so
> the check should be:
>
> if (IS_ERR_OR_NULL(dev))
> return PTR_ERR(dev);
Nice catch, I'll go double check the rest of the return values for this
scenario.
next prev parent reply other threads:[~2016-11-30 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 21:51 [PATCH v2 0/4] SED OPAL Library Scott Bauer
2016-11-29 21:51 ` [PATCH v2 1/4] include: Add definitions for sed Scott Bauer
2016-11-29 21:52 ` [PATCH v2 2/4] block: Add Sed-opal library Scott Bauer
2016-11-30 18:13 ` Keith Busch
2016-11-30 18:09 ` Scott Bauer [this message]
2016-12-01 0:50 ` Keith Busch
2016-12-01 10:04 ` Christoph Hellwig
2016-12-01 17:53 ` Scott Bauer
2016-12-01 18:22 ` Keith Busch
2016-12-09 17:45 ` Scott Bauer
2016-12-09 18:30 ` Christoph Hellwig
2016-12-09 18:50 ` Scott Bauer
2016-11-29 21:52 ` [PATCH v2 3/4] nvme: Implement resume_from_suspend and sed block ioctl Scott Bauer
2016-12-01 0:50 ` Keith Busch
2016-11-29 21:52 ` [PATCH v2 4/4] Maintainers: Add Information for SED Opal library Scott Bauer
2017-02-10 16:46 ` Elliott, Robert (Persistent Memory)
2017-02-10 16:44 ` Scott Bauer
2017-02-11 2:24 ` Elliott, Robert (Persistent Memory)
2017-02-13 8:04 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130180941.GA23789@sbauer-Z170X-UD5 \
--to=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).