From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme/pci: Log PCI_STATUS when the controller dies
Date: Thu, 1 Dec 2016 13:09:43 -0500 [thread overview]
Message-ID: <20161201180943.GG21081@localhost.localdomain> (raw)
In-Reply-To: <CALCETrUt+JtDE1W97xjK+8U=oQFSV-4o4hqRFV_f9tsXUp=qRQ@mail.gmail.com>
On Wed, Nov 30, 2016@10:28:03AM -0800, Andy Lutomirski wrote:
> In theory, although not (AFAIK) on x86, config space reads can fail
> outright. Normally a failure looks like returning 0xffff, so I
> figured I'd make it consistent. I could alternatively check the
> return value and print a different message if pci_read_config_word
> fails.
I agree it'd be nice to know if we actually got all 1's from hardware,
or the pci config read itself returned an error without setting the
status. x86 should be returning all 1's on a failure, but don't want to
always count on that.
prev parent reply other threads:[~2016-12-01 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 1:18 [PATCH] nvme/pci: Log PCI_STATUS when the controller dies Andy Lutomirski
2016-11-30 15:25 ` Jens Axboe
2016-11-30 18:28 ` Andy Lutomirski
2016-12-01 18:09 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201180943.GG21081@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).