From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvmet: delete controllers deletion upon subsystem release
Date: Tue, 6 Dec 2016 09:28:08 +0100 [thread overview]
Message-ID: <20161206082808.GB12194@lst.de> (raw)
In-Reply-To: <72c13127-830a-e3b1-c10c-6992da0502e8@grimberg.me>
On Mon, Dec 05, 2016@07:08:03PM +0200, Sagi Grimberg wrote:
>
>>> No reason for them to be kept around if we are
>>> deleting the subsystem, so instead of passively
>>> wait for the host to disconnect, actively delete
>>> the controllers.
>>
>> Looks fine, but I'd really love to see a testcase for this in some form..
>
> Should we revive the selftests branch?
As-is it's not very usable and would need some major rework. At some
point Chaitanya mentioned he wanted to look into it, but I suspect
he is busy with other things at the moment.
Personally I think we should use nvme-cli and nvmetcli for our tests
instead of opencoding everything, and life would probably be easier
if we wrote it in a proper test framework similar to the nvme-cli
and nvmetcli tests.
next prev parent reply other threads:[~2016-12-06 8:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 11:09 [PATCH 0/3] some useful fabrics patches Sagi Grimberg
2016-12-05 11:09 ` [PATCH 1/3] nvmet: delete controllers deletion upon subsystem release Sagi Grimberg
2016-12-05 11:39 ` Johannes Thumshirn
2016-12-05 14:08 ` Max Gurtovoy
2016-12-05 15:40 ` Christoph Hellwig
2016-12-05 17:08 ` Sagi Grimberg
2016-12-06 8:28 ` Christoph Hellwig [this message]
2016-12-05 11:09 ` [PATCH 2/3] nvmet: Make cntlid globally unique Sagi Grimberg
2016-12-05 11:38 ` Johannes Thumshirn
2016-12-05 14:08 ` Max Gurtovoy
2016-12-05 15:34 ` Christoph Hellwig
2016-12-05 17:06 ` Sagi Grimberg
2016-12-06 8:28 ` Christoph Hellwig
2016-12-06 23:23 ` J Freyensee
2016-12-05 11:09 ` [PATCH 3/3] nvme: Make controller state visible via sysfs Sagi Grimberg
2016-12-05 11:37 ` Johannes Thumshirn
2016-12-05 14:15 ` Max Gurtovoy
2016-12-05 17:05 ` Sagi Grimberg
2016-12-05 15:37 ` Christoph Hellwig
2016-12-05 17:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206082808.GB12194@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).