From: ddstreet@ieee.org (Dan Streetman)
Subject: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 17:03:48 -0500 [thread overview]
Message-ID: <20161207220348.8572-1-ddstreet@ieee.org> (raw)
Change each queue's cq_vector to match its qid, instead of qid - 1.
The first queue is always the admin queue, and the remaining queues are
I/O queues. The interrupt vectors they use are all in the same array,
however, the vector indexes for the admin and I/O queues are setup
differently; the admin queue's cq_vector is manually set to 0, while
each I/O queue's cq_vector is set to qid - 1. Since the admin queue
is qid 0, and the I/O queues start at qid 1, using qid - 1 is wrong for the
I/O queues, as it makes the first I/O queue (qid 1) share the vector from
the admin queue (qid 0), and no queue uses the last interrupt vector.
Instead, each I/O queue should set their cq_vector to qid.
Signed-off-by: Dan Streetman <dan.streetman at canonical.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 5e52034..def2285 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1117,7 +1117,7 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid)
struct nvme_dev *dev = nvmeq->dev;
int result;
- nvmeq->cq_vector = qid - 1;
+ nvmeq->cq_vector = qid;
result = adapter_alloc_cq(dev, qid, nvmeq);
if (result < 0)
return result;
--
2.9.3
next reply other threads:[~2016-12-07 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 22:03 Dan Streetman [this message]
2016-12-07 22:44 ` [PATCH] nvme: use the correct msix vector for each queue Keith Busch
2016-12-07 22:36 ` Dan Streetman
2016-12-07 22:49 ` Keith Busch
2016-12-07 22:46 ` Christoph Hellwig
2016-12-07 22:49 ` Dan Streetman
2016-12-07 22:46 ` Dan Streetman
2016-12-07 23:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207220348.8572-1-ddstreet@ieee.org \
--to=ddstreet@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).