From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: fix KATO offset in Set Features
Date: Fri, 9 Dec 2016 19:28:27 +0100 [thread overview]
Message-ID: <20161209182827.GA16834@lst.de> (raw)
In-Reply-To: <138d5098-5d12-9a06-66c4-14f53770b0ba@intel.com>
On Wed, Dec 07, 2016@12:09:40PM -0700, Daniel Verkamp wrote:
> Should I remove the nvmet_set_result() or fix it to at least return
> the correct units?
Please remove it, as the spec does not define the result. Otherwise
the patch looks fine to me.
Thanks for doing this work! Btw, did you catch this using a test
suite?
next prev parent reply other threads:[~2016-12-09 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 18:39 [PATCH] nvmet: fix KATO offset in Set Features Daniel Verkamp
2016-12-07 19:09 ` Daniel Verkamp
2016-12-09 18:28 ` Christoph Hellwig [this message]
2016-12-09 20:04 ` Daniel Verkamp
2016-12-21 10:27 ` Christoph Hellwig
[not found] ` <830460a5-ce31-b882-8f06-4a906763eb50@broadcom.com>
2016-12-22 6:41 ` Q: nvme_rdma and reconnect Christoph Hellwig
2016-12-22 12:08 ` Sagi Grimberg
2016-12-22 12:10 ` Christoph Hellwig
2016-12-22 12:52 ` Sagi Grimberg
2016-12-22 12:46 ` Hannes Reinecke
2016-12-22 12:50 ` Christoph Hellwig
2016-12-09 19:59 ` [PATCH v2] nvmet: fix KATO offset in Set Features Daniel Verkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209182827.GA16834@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).