linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [patch] nvme-fabrics: correct some printk information
Date: Sat, 10 Dec 2016 12:06:18 +0300	[thread overview]
Message-ID: <20161210090618.GA11680@elgon.mountain> (raw)

We really don't care where "ctrl" is on the stack since we're just
returning soon what we want is the actual ctrl pointer itself.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 771e2e761872..e6395ed2f562 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2402,7 +2402,7 @@ enum blk_eh_timer_return
 
 	dev_info(ctrl->ctrl.device,
 		"NVME-FC{%d}: new ctrl: NQN \"%s\" (%p)\n",
-		ctrl->cnum, ctrl->ctrl.opts->subsysnqn, &ctrl);
+		ctrl->cnum, ctrl->ctrl.opts->subsysnqn, ctrl);
 
 	kref_get(&ctrl->ctrl.kref);
 

             reply	other threads:[~2016-12-10  9:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10  9:06 Dan Carpenter [this message]
2016-12-10 11:27 ` [patch] nvme-fabrics: correct some printk information Joe Perches
2016-12-10 18:55   ` Dan Carpenter
2016-12-10 20:06     ` Julia Lawall
2016-12-10 20:24       ` Dan Carpenter
2016-12-10 20:54       ` Joe Perches
2016-12-10 21:07         ` Dan Carpenter
2016-12-10 22:24           ` Joe Perches
2016-12-12  9:33             ` Dan Carpenter
2016-12-12 15:47               ` Julia Lawall
2016-12-12 15:55                 ` Joe Perches
2016-12-10 22:07         ` Julia Lawall
2016-12-10 22:27           ` Joe Perches
2016-12-11  0:36       ` Joe Perches
2016-12-20  0:40 ` James Smart
2016-12-20  9:16   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161210090618.GA11680@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).