From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-cli: fabrics: remove libudev dependency
Date: Fri, 16 Dec 2016 10:27:04 -0500 [thread overview]
Message-ID: <20161216152703.GA8888@localhost.localdomain> (raw)
In-Reply-To: <20161216080419.GA22912@infradead.org>
On Fri, Dec 16, 2016@12:04:19AM -0800, Christoph Hellwig wrote:
> We can have multiple controllers with the same nqn, and they should all
> be deleted with this option. Also I think factoring the removal code
> in the inner block into a separate function would make this a bit more
> readable.
I also noticed that the description for the 'nqn' field is LIST, but
we're not splitting that item. Was this supposed to be a comma separated
value of nqn's?
Thanks for the other comments; I'll fix those up.
next prev parent reply other threads:[~2016-12-16 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 0:05 [PATCH] nvme-cli: fabrics: remove libudev dependency Keith Busch
2016-12-16 8:04 ` Christoph Hellwig
2016-12-16 15:27 ` Keith Busch [this message]
2016-12-17 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216152703.GA8888@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox