From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVME: Fix CMB types
Date: Sun, 8 Jan 2017 09:18:17 -0800 [thread overview]
Message-ID: <20170108171817.GA20466@infradead.org> (raw)
In-Reply-To: <1483654731-12049-1-git-send-email-jonathan.derrick@intel.com>
On Thu, Jan 05, 2017@03:18:51PM -0700, Jon Derrick wrote:
> ioremapping and the Create SQes command expect a phys_addr_t, so convert
> current usages of dma_addr_t to this type. Also break out the current
> reuse of sq_dma_addr into dma and physical addresses, depending on if
> CMB is being used for SQes.
>
> Reported by: Max Gurtovoy <maxg at mellanox.com>
> Signed-off-by: Jon Derrick <jonathan.derrick at intel.com>
> ---
> Hope this is a good stopgap until we get a more formalized CMB
> management code. Also I don't know whose tree we are using now, so this
> applies to axboe/master
I don't really like the helper with the if - what's the point of having
two variables with different types if we the only user does an implicit
cast to another type. Maybe we should use use u64 instead of either
dma_addr_t or phys_addr_t and add a comment explaining why we do this?
next prev parent reply other threads:[~2017-01-08 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 22:18 [PATCH] NVME: Fix CMB types Jon Derrick
2017-01-08 17:18 ` Christoph Hellwig [this message]
2017-01-09 21:55 ` Jon Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108171817.GA20466@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox