From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 1/3] Sync FC-NVME header with standard
Date: Mon, 9 Jan 2017 15:58:39 +0100 [thread overview]
Message-ID: <20170109145839.GE3711@linux-x5ow.site> (raw)
In-Reply-To: <585eb47e.DESLR9a+kpWyFOqP%jsmart2021@gmail.com>
On Sat, Dec 24, 2016@09:46:38AM -0800, James Smart wrote:
>
> Update FC-NVME definitions to match FC-NVME r1.14 (16-020vB).
> Includes the following:
> - Addition of "status_code" field to ERSP IU
> - Addition of FC-NVME LS RJT reason_codes and reason_explanations
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
[...]
> +/* FC-NVME LS RJT reason_code values */
> +enum fcnvme_ls_rjt_reason {
[...]
> +/* FC-NVME LS RJT reason_explanation values */
> +enum fcnvme_ls_rjt_explan {
[...]
> /* FCNVME_LSDESC_RJT */
> struct fcnvme_lsdesc_rjt {
> @@ -119,8 +169,8 @@ struct fcnvme_lsdesc_rjt {
> * Reject reason and explanaction codes are generic
> * to ELs's from LS-3.
> */
> - u8 reason_code;
> - u8 reason_explanation;
> + u8 reason_code; /* fcnvme_ls_rjt_reason */
> + u8 reason_explanation; /* fcnvme_ls_rjt_explan */
I don't think the comments improve readability all too much.
Otherwise,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2017-01-09 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 17:46 [PATCH 1/3] Sync FC-NVME header with standard James Smart
2017-01-09 14:58 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109145839.GE3711@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox