From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 5/5] nvmet: Call fatal_error from keep-alive timout expiration
Date: Fri, 13 Jan 2017 08:22:23 +0100 [thread overview]
Message-ID: <20170113072223.GB25355@lst.de> (raw)
In-Reply-To: <1484217079-9259-6-git-send-email-sagi@grimberg.me>
On Thu, Jan 12, 2017@12:31:19PM +0200, Sagi Grimberg wrote:
> We only need to call delete_ctrl once, so given that both
> keep-alive timeout and any other fatal error can trigger it,
> just make sure we only call delete_ctrl once.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> drivers/nvme/target/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index dcdc2f6146f1..5267ce20c12d 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -201,7 +201,7 @@ static void nvmet_keep_alive_timer(struct work_struct *work)
> pr_err("ctrl %d keep-alive timer (%d seconds) expired!\n",
> ctrl->cntlid, ctrl->kato);
>
> - ctrl->ops->delete_ctrl(ctrl);
> + nvmet_ctrl_fatal_error(ctrl);
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2017-01-13 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 10:31 [PATCH 0/5] nvme fabrics patches Sagi Grimberg
2017-01-12 10:31 ` [PATCH 1/5] nvmet: delete controllers deletion upon subsystem release Sagi Grimberg
2017-01-12 10:31 ` [PATCH 2/5] nvmet: Make cntlid globally unique Sagi Grimberg
2017-01-12 10:31 ` [PATCH 3/5] nvme: Make controller state visible via sysfs Sagi Grimberg
2017-01-12 10:31 ` [PATCH 4/5] nvmet: cancel fatal error and flush async work before free controller Sagi Grimberg
2017-01-13 7:21 ` Christoph Hellwig
2017-01-12 10:31 ` [PATCH 5/5] nvmet: Call fatal_error from keep-alive timout expiration Sagi Grimberg
2017-01-13 7:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113072223.GB25355@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox