From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet-rdma: Fix missing dma sync to nvme data structures
Date: Mon, 16 Jan 2017 16:31:09 +0100 [thread overview]
Message-ID: <20170116153109.GA16170@lst.de> (raw)
In-Reply-To: <1484412337-10860-1-git-send-email-parav@mellanox.com>
> +++ b/drivers/nvme/target/rdma.c
> @@ -438,6 +438,14 @@ static int nvmet_rdma_post_recv(struct nvmet_rdma_device *ndev,
> {
> struct ib_recv_wr *bad_wr;
>
> + ib_dma_sync_single_for_device(ndev->device,
> + cmd->sge[0].addr, sizeof(*cmd->nvme_cmd),
> + DMA_FROM_DEVICE);
> +
> + if (cmd->sge[1].addr)
0 can be a valid address returned from dma_map_single on some
architectures.
next prev parent reply other threads:[~2017-01-16 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 16:45 [PATCH] nvmet-rdma: Fix missing dma sync to nvme data structures Parav Pandit
2017-01-14 21:07 ` Sagi Grimberg
2017-01-16 15:31 ` Christoph Hellwig [this message]
2017-01-16 17:18 ` Parav Pandit
2017-01-16 17:30 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-01-12 22:45 Parav Pandit
2017-01-13 7:44 ` Christoph Hellwig
2017-01-13 15:08 ` Parav Pandit
2017-01-13 19:42 ` Sagi Grimberg
2017-01-13 19:50 ` Parav Pandit
2017-01-13 20:01 ` Sagi Grimberg
2017-01-14 16:12 ` Parav Pandit
2017-01-14 21:00 ` Sagi Grimberg
2017-01-14 16:18 ` Christoph Hellwig
2017-01-14 21:04 ` Sagi Grimberg
2017-01-13 19:35 ` Sagi Grimberg
2017-01-12 22:42 Parav Pandit
2017-01-12 22:45 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116153109.GA16170@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox