From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] nvme: add semicolon in nvme_command setting
Date: Thu, 26 Jan 2017 12:08:21 -0500 [thread overview]
Message-ID: <20170126170821.GA1048@localhost.localdomain> (raw)
In-Reply-To: <1485443848-29478-1-git-send-email-maxg@mellanox.com>
On Thu, Jan 26, 2017@05:17:27PM +0200, Max Gurtovoy wrote:
> Reviewed-by: Parav Pandit <parav at mellanox.com>
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
Reviewed-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 8a3c3e3..4300f88 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -568,8 +568,8 @@ int nvme_identify_ns(struct nvme_ctrl *dev, unsigned nsid,
> int error;
>
> /* gcc-4.4.4 (at least) has issues with initializers and anon unions */
> - c.identify.opcode = nvme_admin_identify,
> - c.identify.nsid = cpu_to_le32(nsid),
> + c.identify.opcode = nvme_admin_identify;
> + c.identify.nsid = cpu_to_le32(nsid);
>
> *id = kmalloc(sizeof(struct nvme_id_ns), GFP_KERNEL);
> if (!*id)
> --
> 1.7.1
>
prev parent reply other threads:[~2017-01-26 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:17 [PATCH 1/2] nvme: add semicolon in nvme_command setting Max Gurtovoy
2017-01-26 15:17 ` [PATCH 2/2] nvme: Use CNS as 8-bit field and avoid endianness conversion Max Gurtovoy
2017-01-26 17:09 ` Keith Busch
2017-01-26 17:08 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126170821.GA1048@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox