From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 4/4] nvme: support ranged discard requests
Date: Tue, 7 Feb 2017 13:34:54 -0500 [thread overview]
Message-ID: <20170207183453.GC10133@localhost.localdomain> (raw)
In-Reply-To: <20170207164658.32449-5-hch@lst.de>
On Tue, Feb 07, 2017@05:46:58PM +0100, Christoph Hellwig wrote:
> @@ -1233,6 +1243,8 @@ static void nvme_set_queue_limits(struct nvme_ctrl *ctrl,
> if (ctrl->vwc & NVME_CTRL_VWC_PRESENT)
> vwc = true;
> blk_queue_write_cache(q, vwc, vwc);
> + blk_queue_max_discard_segments(q,
> + PAGE_SIZE / sizeof(struct nvme_dsm_range));
We need to use ctrl->page_size rather than PAGE_SIZE.
Otherwise, this looks really good!
next prev parent reply other threads:[~2017-02-07 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 16:46 support for multi-range discard requests Christoph Hellwig
2017-02-07 16:46 ` [PATCH 1/4] block: move req_set_nomerge to blk.h Christoph Hellwig
2017-02-15 10:29 ` Sagi Grimberg
2017-02-07 16:46 ` [PATCH 2/4] block: enumify ELEVATOR_*_MERGE Christoph Hellwig
2017-02-15 10:31 ` Sagi Grimberg
2017-02-07 16:46 ` [PATCH 3/4] block: optionally merge discontiguous discard bios into a single request Christoph Hellwig
2017-02-08 10:54 ` Ming Lei
2017-02-08 11:57 ` Christoph Hellwig
2017-02-15 10:36 ` Sagi Grimberg
2017-02-07 16:46 ` [PATCH 4/4] nvme: support ranged discard requests Christoph Hellwig
2017-02-07 18:34 ` Keith Busch [this message]
2017-02-07 19:34 ` Christoph Hellwig
2017-02-15 10:42 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2017-02-08 13:13 support for multi-range discard requests V2 Christoph Hellwig
2017-02-08 13:13 ` [PATCH 4/4] nvme: support ranged discard requests Christoph Hellwig
[not found] ` <CANvN+ekrmaCZaYt02wX1DRz4+hTLicjyP-tYDTTcKsWe2Lo5MQ@mail.gmail.com>
2017-02-08 13:36 ` Christoph Hellwig
2017-02-08 13:46 support for multi-range discard requests V3 Christoph Hellwig
2017-02-08 13:46 ` [PATCH 4/4] nvme: support ranged discard requests Christoph Hellwig
2017-02-15 10:45 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207183453.GC10133@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox