Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: snitzer@redhat.com (Mike Snitzer)
Subject: hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme]
Date: Thu, 16 Feb 2017 15:23:39 -0500	[thread overview]
Message-ID: <20170216202339.GB13742@redhat.com> (raw)
In-Reply-To: <1487274356.2612.5.camel@sandisk.com>

On Thu, Feb 16 2017 at  2:46pm -0500,
Bart Van Assche <Bart.VanAssche@sandisk.com> wrote:

> On Thu, 2017-02-16@07:37 -0500, Mike Snitzer wrote:
> > Weird.  I did push back on those changes initially (just felt like
> > churn) but I ultimately did take them:
> > 
> > $ git log --oneline --author=bart drivers/md/dm-mpath.c
> > 6599c84 dm mpath: do not modify *__clone if blk_mq_alloc_request() fails
> > 4813577 dm mpath: change return type of pg_init_all_paths() from int to void
> > 9f4c3f8 dm: convert wait loops to use autoremove_wake_function()
> > 
> > Did I miss any?
> 
> Hello Mike,
> 
> Thank you for having accepted these patches. However, I was not referring
> to these patches but to the eight patches available at
> https://github.com/bvanassche/linux/tree/dm-mpath

Some of these look familiar (the dm-mpath micro-optimize one made me
cringe.. potential for regression, etc.  But careful review should ease
those concerns).  But yeah, these certainly slipped through the cracks.
I'll review these for 4.12 (too late for 4.11, sorry)

Please rebase these ontop of linux-block.git's for-4.11/rq-refactor
because Christoph significantly reworked the request-based DM code (all
request allocation is done in DM multipath now), see:
http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.11/rq-refactor&id=eb8db831be80692bf4bda3dfc55001daf64ec299

Or you can wait to rebase on v4.11-rc1 in ~2 weeks.

Thanks

  reply	other threads:[~2017-02-16 20:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1487107154-24883-1-git-send-email-keith.busch@intel.com>
     [not found] ` <20170215145617.GA4241@infradead.org>
2017-02-16  2:53   ` hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme] Mike Snitzer
2017-02-16  5:00     ` [dm-devel] " Bart Van Assche
2017-02-16 12:37       ` Mike Snitzer
2017-02-16 19:46         ` Bart Van Assche
2017-02-16 20:23           ` Mike Snitzer [this message]
2017-02-16 20:58             ` Bart Van Assche
2017-02-16 14:26     ` [dm-devel] " Christoph Hellwig
2017-02-16 15:13       ` Mike Snitzer
2017-02-16 17:38         ` Keith Busch
2017-02-16 17:37           ` Bart Van Assche
2017-02-16 18:07             ` Keith Busch
2017-02-16 18:21               ` Mike Snitzer
2017-02-16 20:40                 ` Keith Busch
2017-02-17  9:04                 ` [dm-devel] " hch
2017-02-17 14:43                   ` Mike Snitzer
2017-02-16 18:05         ` Sagi Grimberg
2017-02-17  9:05           ` [dm-devel] " Christoph Hellwig
2017-02-17 14:37             ` Mike Snitzer
2017-02-17  9:33         ` [dm-devel] " Christoph Hellwig
2017-02-17 14:32           ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216202339.GB13742@redhat.com \
    --to=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox