From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper
Date: Tue, 21 Feb 2017 23:43:54 -0800 [thread overview]
Message-ID: <20170222074354.GA19012@infradead.org> (raw)
In-Reply-To: <6c2a4f67-ede6-0ee1-5a90-14023994d029@grimberg.me>
On Tue, Feb 21, 2017@11:18:04PM +0200, Sagi Grimberg wrote:
> I can maybe do something like:
>
> if (af == AF_INET || af == AF_UNSPEC) {
> ret = inet4_pton();
> if (!ret)
> return 0;
> else if (af != AF_UNSPEC)
> return ret;
> }
>
> if (af == AF_INET6 || af == AF_UNSPEC) {
> ret = inet6_pton();
> if (!ret)
> return 0;
> else if (af != AF_UNSPEC)
> return ret;
> }
>
> return -EINVAL;
>
> better?
My idead was the following:
switch (af) {
case AF_INET:
ret = inet_pton();
break;
case AF_INET6:
ret = inet6_pton();
break;
case AF_UNSPEC:
ret = inet6_pton();
if (ret)
ret = inet_pton();
break;
}
next prev parent reply other threads:[~2017-02-22 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 17:43 [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper Sagi Grimberg
2017-02-16 21:34 ` kbuild test robot
2017-02-16 21:34 ` [PATCH] net/utils: fix semicolon.cocci warnings kbuild test robot
2017-02-17 18:52 ` David Miller
2017-02-17 19:19 ` Keith Busch
2017-02-18 0:39 ` Fengguang Wu
2017-02-19 17:15 ` [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper Christoph Hellwig
2017-02-21 21:18 ` Sagi Grimberg
2017-02-22 7:43 ` Christoph Hellwig [this message]
2017-02-16 17:43 ` [PATCH rfc 2/4] nvmet-rdma: use generic inet_pton_with_scope Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 3/4] nvme-rdma: use inet_pton_with_scope helper Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 4/4] iscsi-target: use generic inet_pton_with_scope Sagi Grimberg
2017-02-19 5:54 ` Nicholas A. Bellinger
2017-02-16 17:50 ` [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address Chuck Lever
2017-02-16 17:53 ` Sagi Grimberg
2017-02-16 17:59 ` Chuck Lever
2017-02-16 18:11 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222074354.GA19012@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox