Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2 2/2] nvme: Complete all stuck requests
Date: Mon, 27 Feb 2017 14:15:00 -0500	[thread overview]
Message-ID: <20170227191459.GA1170@localhost.localdomain> (raw)
In-Reply-To: <4c952c67-9871-249d-86b0-5f81acf00571@grimberg.me>

On Mon, Feb 27, 2017@07:27:51PM +0200, Sagi Grimberg wrote:
> OK, I think we can get it for fabrics too, need to figure out how to
> handle it there too.
> 
> Do you have a reproducer?

To repro, I have to run a buffered writer workload then put the system into S3.

This fio job seems to reproduce for me:

  fio --name=global --filename=/dev/nvme0n1 --bsrange=4k-128k --rw=randwrite --ioengine=libaio --iodepth=8 --numjobs=8 --name=foobar

I use rtcwake to test suspend/resume:

  rtcwake -m mem -s 10

Without the patch we'll get stuck after "Disabling non-boot CPUs ..."
when blk-mq waits to freeze some entered queues after nvme was disabled.

  reply	other threads:[~2017-02-27 19:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24  0:36 [PATCHv2 1/2] blk-mq: Export blk_mq_freeze_queue_wait Keith Busch
2017-02-24  0:36 ` [PATCHv2 2/2] nvme: Complete all stuck requests Keith Busch
2017-02-24  6:50   ` Christoph Hellwig
2017-02-27 13:46   ` Sagi Grimberg
2017-02-27 15:01     ` Keith Busch
2017-02-27 17:27       ` Sagi Grimberg
2017-02-27 19:15         ` Keith Busch [this message]
2017-02-28  7:42           ` Artur Paszkiewicz
2017-02-28 11:45             ` Sagi Grimberg
2017-02-28 16:57             ` Keith Busch
2017-03-01  8:54               ` Artur Paszkiewicz
2017-02-24  6:49 ` [PATCHv2 1/2] blk-mq: Export blk_mq_freeze_queue_wait Christoph Hellwig
2017-02-27 13:38 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227191459.GA1170@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox