From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: make nvme error status codes converted to errno detailed
Date: Thu, 30 Mar 2017 13:22:37 -0400 [thread overview]
Message-ID: <20170330172236.GG20181@localhost.localdomain> (raw)
In-Reply-To: <e81a210c-a911-b275-eb53-51ee9f3f7c5e@huawei.com>
On Thu, Mar 30, 2017@07:32:50PM +0800, guanjunxiong wrote:
> Current block layer ends the requests with errors and logs different errno in a
> human readable string. So I think the detailed conversion above make sense.Also ,
> as Sagi said, It'll be useful if we can log the specific error (as a human readable
> string).
> Anyway, since this patch would conflict with your rework in this area,
> I decide to suspend this patch.
> BTW, what's the plan of your rework in this area?
I don't see a problem having more appropriate errno's here. The block
layer looks okay to accept any value, and the spec folks might be happy
to see their thought out status codes don't all become EIO. :)
But just so we all know, the majority of those statuses are only possible
to encounter with passthrough, and those are not translated to errno.
next prev parent reply other threads:[~2017-03-30 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 10:08 [PATCH] nvme: make nvme error status codes converted to errno detailed Guan Junxiong
2017-03-29 17:39 ` Sagi Grimberg
2017-03-30 8:05 ` guanjunxiong
2017-03-30 8:11 ` Christoph Hellwig
2017-03-30 11:32 ` guanjunxiong
2017-03-30 17:22 ` Keith Busch [this message]
2017-03-30 17:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330172236.GG20181@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).