From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/5] nvme: move the retries count to struct nvme_request
Date: Wed, 5 Apr 2017 17:25:11 +0200 [thread overview]
Message-ID: <20170405152511.GA6435@lst.de> (raw)
In-Reply-To: <20170405151430.GS20181@localhost.localdomain>
On Wed, Apr 05, 2017@11:14:30AM -0400, Keith Busch wrote:
> On Wed, Apr 05, 2017@04:18:55PM +0200, Christoph Hellwig wrote:
> > The way NVMe uses this field is entirely different from the older
> > SCSI/BLOCK_PC usage, so move it into struct nvme_request.
> >
> > Also reduce the size of the file to a unsigned char so that we leave space
> > for additional smaller fields that will appear soon.
>
> What new fields can we expect? Why temporarily pad the middle of the
> struct instead of appending to the end? The "result" packed nicely
> on 64-bit, at least.
I've got another u8 and a u16 in pending patches. That being said
moving it to the end might make sense.
next prev parent reply other threads:[~2017-04-05 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 14:18 ->retries fixups Christoph Hellwig
2017-04-05 14:18 ` [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd Christoph Hellwig
2017-04-05 14:43 ` Johannes Thumshirn
2017-04-05 14:50 ` Christoph Hellwig
2017-04-05 14:18 ` [PATCH 2/5] nvme: cleanup nvme_req_needs_retry Christoph Hellwig
2017-04-05 14:42 ` Johannes Thumshirn
2017-04-05 14:18 ` [PATCH 3/5] nvme: mark nvme_max_retries static Christoph Hellwig
2017-04-05 14:44 ` Johannes Thumshirn
2017-04-05 14:18 ` [PATCH 4/5] nvme: move the retries count to struct nvme_request Christoph Hellwig
2017-04-05 14:45 ` Johannes Thumshirn
2017-04-05 15:14 ` Keith Busch
2017-04-05 15:25 ` Christoph Hellwig [this message]
[not found] ` <5a5f1f1.8f7d.15b4267e21e.Coremail.liaohengquan1986@163.com>
2017-04-06 8:38 ` Christoph Hellwig
2017-04-05 14:18 ` [PATCH 5/5] block, scsi: move the retries field to struct scsi_request Christoph Hellwig
2017-04-05 14:46 ` Johannes Thumshirn
-- strict thread matches above, loose matches on Subject: below --
2017-04-05 17:18 ->retries fixups V2 Christoph Hellwig
2017-04-05 17:18 ` [PATCH 4/5] nvme: move the retries count to struct nvme_request Christoph Hellwig
2017-04-05 17:33 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405152511.GA6435@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).