From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_unmap_data()
Date: Thu, 6 Apr 2017 16:53:40 +0200 [thread overview]
Message-ID: <20170406145340.GD3768@linux-x5ow.site> (raw)
In-Reply-To: <1491488190-5564-1-git-send-email-emilne@redhat.com>
Hi Ewan,
On Thu, Apr 06, 2017@10:16:30AM -0400, Ewan Milne wrote:
> nvme_cleanup_cmd() is already called by callers of nvme_unmap_data().
nvme_fc_unmap_data()? ^
And besides this, in nvme_fc_complete_rq() it is called before
nvme_fc_unmap_data() in nvme_fc_start_fcp_op() afterwards. Even if this is a
correct behaviour (i.e. doesn't harm as we're not touching
req->special_vec.bv_page in nvme_fc_unmap_data() it at a first sight looks
like an error. Care to adjust it?
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2017-04-06 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 14:16 [PATCH] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_unmap_data() Ewan D. Milne
2017-04-06 14:53 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406145340.GD3768@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).