From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2] nvme-rdma: support devices with queue size < 32
Date: Mon, 10 Apr 2017 17:16:57 +0200 [thread overview]
Message-ID: <20170410151657.GA15173@lst.de> (raw)
In-Reply-To: <1519881025.363156294.1491837154312.JavaMail.zimbra@kalray.eu>
> +static inline nvme_rdma_queue_sig_limit(struct nvme_rdma_queue *queue)
> +{
> + int sig_limit;
> +
> + /* We signal completion every queue depth/2 and also
> + * handle the case of possible device with queue_depth=1,
> + * where we would need to signal every message.
> + */
> + sig_limit = max(queue->queue_size / 2, 1);
> + return (++queue->sig_count % sig_limit) == 0;
> +}
I would love if we could do this at the ib_qp level. I also know
you found a real bug and we want it fixed ASAP, so maybe for now
we should merge this one:
Reviewed-by: Christoph Hellwig <hch at lst.de>
and then do the generic version. Marta, do you want to tackle the
generic version or should I look into this once I get a little time.
next prev parent reply other threads:[~2017-04-10 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 15:12 [PATCH v2] nvme-rdma: support devices with queue size < 32 Marta Rybczynska
2017-04-10 15:16 ` Christoph Hellwig [this message]
2017-04-10 15:21 ` Marta Rybczynska
2017-04-10 15:27 ` Bart Van Assche
2017-04-10 15:31 ` hch
2017-04-10 15:32 ` Bart Van Assche
2017-04-11 8:52 ` Marta Rybczynska
2017-04-11 10:50 ` Max Gurtovoy
2017-04-11 11:04 ` Marta Rybczynska
2017-04-11 15:10 ` Bart Van Assche
2017-04-20 9:43 ` [PATCH v3] " Marta Rybczynska
2017-04-20 11:37 ` Sagi Grimberg
2017-04-20 11:43 ` Sagi Grimberg
2017-04-21 8:01 ` Marta Rybczynska
2017-05-22 18:51 ` [PATCH v2] " Christoph Hellwig
2017-05-23 15:32 ` Marta Rybczynska
2017-06-05 9:47 ` Marta Rybczynska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410151657.GA15173@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).