From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH] nvme/pci: Poll CQ on timeout
Date: Thu, 20 Apr 2017 10:56:09 +0200 [thread overview]
Message-ID: <20170420085609.GA6217@linux-x5ow.site> (raw)
In-Reply-To: <6c0cacb0-ab91-6270-8bae-dbd18a8dbd0e@fb.com>
On Tue, Feb 28, 2017@10:44:21AM -0700, Jens Axboe wrote:
> IMHO that can go at a later time, if we do remove polling for
> specific entries. For now it's fine.
>
> And I do think this is a nice addition - it's free, and it provides
> us extra info for debugging an issue. That's a big deal, especially
> if it's a user report.
JFYI, we did have I/O timeout issues on one of our internal systems.
Keith suggested to give this patch a shot and indeed it cought missed IRQs,
which after being polled at least didn't result in filesystem errors.
So if you want you can have my:
Tested-by: Johannes Thumshirn <jthumshirn at suse.de>
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-04-20 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 22:59 [PATCH] nvme/pci: Poll CQ on timeout Keith Busch
2017-02-27 14:42 ` Sagi Grimberg
2017-02-28 14:10 ` Christoph Hellwig
2017-02-28 16:00 ` Keith Busch
2017-02-28 17:44 ` Jens Axboe
2017-04-20 8:56 ` Johannes Thumshirn [this message]
2017-04-20 14:20 ` Keith Busch
2017-04-20 15:45 ` Jens Axboe
2017-04-20 16:17 ` Sagi Grimberg
2017-04-20 16:28 ` Keith Busch
2017-04-20 16:31 ` Jens Axboe
2017-04-21 6:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420085609.GA6217@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox