Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/7] nvme/fc: don't byte swap command_id
Date: Sun, 23 Apr 2017 09:43:04 +0200	[thread overview]
Message-ID: <20170423074304.GA20750@lst.de> (raw)
In-Reply-To: <769f8c7a-4d95-3140-1e6f-817a0e7f97b4@broadcom.com>

On Fri, Apr 21, 2017@06:10:28PM -0700, James Smart wrote:
> On 4/21/2017 1:50 AM, Christoph Hellwig wrote:
>> The command ID is a field for host only use and thus always is in
>> native endian.
>>
>> Found by sparse.
>>
>> Signed-off-by: Christoph Hellwig <hch at lst.de>
>> ---
>>   drivers/nvme/host/fc.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
>> index 63819b12c1da..68887818801e 100644
>> --- a/drivers/nvme/host/fc.c
>> +++ b/drivers/nvme/host/fc.c
>> @@ -1274,7 +1274,7 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req)
>>   			     be32_to_cpu(op->rsp_iu.xfrd_len) !=
>>   					freq->transferred_length ||
>>   			     op->rsp_iu.status_code ||
>> -			     op->rqno != le16_to_cpu(cqe->command_id))) {
>> +			     op->rqno != cqe->command_id)) {
>>   			status = cpu_to_le16(NVME_SC_FC_TRANSPORT_ERROR << 1);
>>   			goto done;
>>   		}
>
> This check was replaced in the following patch, obsoleting this change:
> http://lists.infradead.org/pipermail/linux-nvme/2017-April/009259.html

Can you please resend this and the two patches related to it?  They had
non-trivial conflicts with the error status rework.

  reply	other threads:[~2017-04-23  7:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21  8:49 sparse fixes for nvme/fc Christoph Hellwig
2017-04-21  8:49 ` [PATCH 1/7] nvme/fc: mark two symbols static Christoph Hellwig
2017-04-21  8:54   ` Johannes Thumshirn
2017-04-22  1:06   ` James Smart
2017-04-21  8:50 ` [PATCH 2/7] nvme/fc: don't byte swap command_id Christoph Hellwig
2017-04-21  8:54   ` Johannes Thumshirn
2017-04-22  1:10   ` James Smart
2017-04-23  7:43     ` Christoph Hellwig [this message]
2017-04-23 15:32       ` James Smart
2017-04-21  8:50 ` [PATCH 3/7] nvmet/fc: mark nvmet_fc_handle_fcp_rqst static Christoph Hellwig
2017-04-21  8:55   ` Johannes Thumshirn
2017-04-21  8:50 ` [PATCH 4/7] nvmet/fc: fix endianess annoations for nvmet_fc_format_rsp_hdr Christoph Hellwig
2017-04-21  8:55   ` Johannes Thumshirn
2017-04-21  8:50 ` [PATCH 5/7] nvmet/fc: mark the sqhd field as __le16 Christoph Hellwig
2017-04-21  8:56   ` Johannes Thumshirn
     [not found]   ` <01043680-3084-a345-96b1-9820a45f3ed6@broadcom.com>
2017-04-23  7:40     ` Christoph Hellwig
2017-04-21  8:50 ` [PATCH 6/7] nvmet/fc: properly endian swap sq_head Christoph Hellwig
2017-04-21  8:57   ` Johannes Thumshirn
2017-04-21  8:50 ` [PATCH 7/7] nvmet/fcloop: mark two symbols static Christoph Hellwig
2017-04-21  8:57   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170423074304.GA20750@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox