Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: change cq_vector to a bool and set to true after request_irq
Date: Sun, 23 Apr 2017 09:47:10 +0200	[thread overview]
Message-ID: <20170423074710.GB20750@lst.de> (raw)
In-Reply-To: <1492817055-33601-1-git-send-email-sandeep@purestorage.com>

nvmeq_irq went away in a commit in the PCI tree, so merging this now
would create a bit of a merge problem.  Either we can live with the
conflict or delay the patch until the first round of merges for -rc1
are done..

> +	bool cq_vector;

I think the field is badly misnamed now.  Something like a flags
field with an NVME_PCI_Q_IS_ALIVE flag might be more suitable now?

  reply	other threads:[~2017-04-23  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 23:24 [PATCH] nvme: change cq_vector to a bool and set to true after request_irq Sandeep Mann
2017-04-23  7:47 ` Christoph Hellwig [this message]
2017-04-23 15:16   ` Sagi Grimberg
2017-04-24 20:25   ` Sandeep Mann
2017-04-25  7:18     ` Christoph Hellwig
2017-05-10 17:16 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2017-04-21 23:23 No subject Sandeep Mann
2017-04-21 23:23 ` [PATCH] nvme: change cq_vector to a bool and set to true after request_irq Sandeep Mann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170423074710.GB20750@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox