From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/1] nvme-fc: avoid memory corruption caused by calling nvmf_free_options() twice
Date: Tue, 25 Apr 2017 10:57:44 -0700 [thread overview]
Message-ID: <20170425175744.GA3575@infradead.org> (raw)
In-Reply-To: <20170425175402.GA24999@infradead.org>
On Tue, Apr 25, 2017@10:54:02AM -0700, Christoph Hellwig wrote:
> On Mon, Apr 24, 2017@01:24:16PM -0400, Ewan D. Milne wrote:
> > From: "Ewan D. Milne" <emilne at redhat.com>
> >
> > Do not call nvmf_free_options() from the nvme_fc_ctlr destructor if
> > nvme_fc_create_ctrl() returns an error, because nvmf_create_ctrl()
> > frees the options when an error is returned.
> >
> > Signed-off-by: Ewan D. Milne <emilne at redhat.com>
>
> Looks good, applied to nvme-4.12.
Actually, it doesn't apply at all. Can you respin it?
next prev parent reply other threads:[~2017-04-25 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 17:24 [PATCH 0/1] Fix crash when failing to connect to FC NVMe target Ewan D. Milne
2017-04-24 17:24 ` [PATCH 1/1] nvme-fc: avoid memory corruption caused by calling nvmf_free_options() twice Ewan D. Milne
2017-04-25 17:54 ` Christoph Hellwig
2017-04-25 17:57 ` Christoph Hellwig [this message]
2017-04-25 18:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425175744.GA3575@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox