From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2] nvmet core: skip flags checks on fabric commands
Date: Fri, 28 Apr 2017 07:28:12 -0700 [thread overview]
Message-ID: <20170428142812.GA30820@infradead.org> (raw)
In-Reply-To: <20170428030414.27185-1-jsmart2021@gmail.com>
On Thu, Apr 27, 2017@08:04:14PM -0700, jsmart2021@gmail.com wrote:
> From: James Smart <jsmart2021 at gmail.com>
>
> The core layer validates nvme command flags (w0 byte 1) values before
> decoding opcodes. On fabric commands the flags field is reserved.
> Current validations require NVME_CMD_SGL_METABUF or NVME_CMD_SGL_METASEG
> to be set. If host sets flags to 0 as reserved field, command fails.
>
> Exclude fabric commands from flags checks.
Eww. I'd rather talk to the working group and get this fixed in an
errata. Treating a field special for fabrics command does not make
sense.
prev parent reply other threads:[~2017-04-28 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 3:04 [PATCH v2] nvmet core: skip flags checks on fabric commands jsmart2021
2017-04-28 14:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428142812.GA30820@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox