From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet: release the sq ref on rdma read errors
Date: Thu, 4 May 2017 10:56:31 +0200 [thread overview]
Message-ID: <20170504085631.GA5584@lst.de> (raw)
In-Reply-To: <00d6f8bf-07bd-03ca-3060-fd3def1ef1d7@grimberg.me>
On Thu, May 04, 2017@08:50:56AM +0300, Sagi Grimberg wrote:
> While it is true that we need to drop the reference on
> the nvmet_sq, there is no point in queuing a response
> message because the rdma qp is in error state and the response
> will never make it to the host.
Yeah.
> I think we should explicitly drop the sq reference and release
> the rsp and avoid triggering the TX path, and provide a detailed
> comment on why we are doing this. Maybe a nicer way to do this,
> is to introduce a nvme_req_uninit() that would take care of
> it in the right layer (that is nvmet core).
Agreed.
next prev parent reply other threads:[~2017-05-04 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN9s3O597CB9d2BoPx1gL5a7NnqhxrXYMhE==Q3E8+BoDxRFiQ@mail.gmail.com>
[not found] ` <01cb01d2c446$20cd83a0$62688ae0$@attalasystems.com>
2017-05-03 19:51 ` [PATCH] nvmet: release the sq ref on rdma read errors Vijay Immanuel
2017-05-03 20:23 ` Sagi Grimberg
2017-05-04 5:50 ` Sagi Grimberg
2017-05-04 8:56 ` Christoph Hellwig [this message]
2017-05-04 10:46 ` Sagi Grimberg
2017-05-04 22:51 ` Vijay Immanuel
2017-05-06 20:31 ` Sagi Grimberg
2017-05-10 16:55 ` Christoph Hellwig
2017-05-10 16:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504085631.GA5584@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox