Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/4] nvme-pci: implement host memory buffer support
Date: Mon, 22 May 2017 14:48:36 +0200	[thread overview]
Message-ID: <20170522124836.GC11869@lst.de> (raw)
In-Reply-To: <20170522072229.GI7850@localhost.localdomain>

On Mon, May 22, 2017@03:22:30AM -0400, Keith Busch wrote:
> > +out_free_bufs:
> > +	while (--i >= 0) {
> > +		struct nvme_host_mem_buf_desc *desc = &dev->host_mem_descs[i];
> 
> I think you want to use the local desc's variable since
> dev->host_mem_descs isn't set if you goto this out_free_bufs label.

Indeed..

  reply	other threads:[~2017-05-22 12:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20 13:13 host memory buffer support Christoph Hellwig
2017-05-20 13:13 ` [PATCH 1/4] nvme.h: add struct nvme_host_mem_buf_desc and HMB flags Christoph Hellwig
2017-05-30 14:31   ` Sagi Grimberg
2017-05-20 13:13 ` [PATCH 2/4] nvme.h: add dword 12 - 15 fields to struct nvme_features Christoph Hellwig
2017-05-30 14:31   ` Sagi Grimberg
2017-05-20 13:13 ` [PATCH 3/4] nvme: save hmpre and hmmin in struct nvme_ctrl Christoph Hellwig
2017-05-30 14:31   ` Sagi Grimberg
2017-05-20 13:13 ` [PATCH 4/4] nvme-pci: implement host memory buffer support Christoph Hellwig
2017-05-22  7:22   ` Keith Busch
2017-05-22 12:48     ` Christoph Hellwig [this message]
2017-05-30 14:35   ` Sagi Grimberg
2017-05-30 21:39   ` Max Gurtovoy
2017-06-01  7:18     ` Christoph Hellwig
2017-06-01  9:19       ` Max Gurtovoy
  -- strict thread matches above, loose matches on Subject: below --
2017-06-01 11:27 host memory buffer support V2 Christoph Hellwig
2017-06-01 11:27 ` [PATCH 4/4] nvme-pci: implement host memory buffer support Christoph Hellwig
2017-06-01 12:58   ` Keith Busch
2017-06-01 14:56   ` Max Gurtovoy
2017-06-02  7:52   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522124836.GC11869@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox