Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v3 2/3] nvmet_fc: Reduce work_q count
Date: Tue, 23 May 2017 00:15:28 -0700	[thread overview]
Message-ID: <20170523071528.GB16776@infradead.org> (raw)
In-Reply-To: <20170522222844.22494-3-jsmart2021@gmail.com>

On Mon, May 22, 2017@03:28:43PM -0700, James Smart wrote:
> Instead of a work_q per controller queue, use system workqueues.
> Create "work lists" per cpu that driver ISR posts to and workqueue
> pulls from.

Why?  The whole point of workqueues is to avoid this sort of open coded
work lists in drivers.  To me it seems like you should simply make
the existing workqueue global, and maybe mark it as cpu itensive based
on profiling, but that's about it.

  reply	other threads:[~2017-05-23  7:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 22:28 [PATCH v3 0/3] outstanding nvme_fc/nvmet_fc fixes James Smart
2017-05-22 22:28 ` [PATCH v3 1/3] nvme_fc: replace ioabort msleep loop with completion James Smart
2017-05-23  7:12   ` Christoph Hellwig
2017-05-22 22:28 ` [PATCH v3 2/3] nvmet_fc: Reduce work_q count James Smart
2017-05-23  7:15   ` Christoph Hellwig [this message]
2017-05-23 19:31     ` James Smart
2017-05-24 17:35       ` Christoph Hellwig
2017-05-22 22:28 ` [PATCH v3 3/3] nvme_fcloop: fix port deletes and callbacks James Smart
2017-05-23  7:16   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523071528.GB16776@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox