From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/3] nvme: only setup block integrity if supported by the driver
Date: Thu, 25 May 2017 06:21:57 -0400 [thread overview]
Message-ID: <20170525102157.GC24894@localhost.localdomain> (raw)
In-Reply-To: <20170520131445.16078-3-hch@lst.de>
On Sat, May 20, 2017@03:14:45PM +0200, Christoph Hellwig wrote:
> Currently only the PCIe driver supports metadata, so we should not claim
> integrity support for the other drivers. This prevents nasty crashes
> with targets that advertise metadata support on fabrics.
>
> Also use the opportunity to factor out some code into a separate helper
> that isn't even compiled if CONFIG_BLK_DEV_INTEGRITY is disabled.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2017-05-25 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 13:14 [PATCH 1/3] nvme-pci: consistencly use ctrl->device for logging Christoph Hellwig
2017-05-20 13:14 ` [PATCH 2/3] nvme: replace is_flags field in nvme_ctrl_ops with a flags field Christoph Hellwig
2017-05-25 10:21 ` Keith Busch
2017-05-20 13:14 ` [PATCH 3/3] nvme: only setup block integrity if supported by the driver Christoph Hellwig
2017-05-25 8:33 ` Christoph Hellwig
2017-05-25 10:21 ` Keith Busch [this message]
2017-05-25 10:20 ` [PATCH 1/3] nvme-pci: consistencly use ctrl->device for logging Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525102157.GC24894@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox