From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v1 6/7] nvme: change magic 4096 to SZ_4K
Date: Thu, 1 Jun 2017 08:50:29 +0200 [thread overview]
Message-ID: <20170601065029.GF16778@lst.de> (raw)
In-Reply-To: <9d231ec2f7b34221685a305ecb02d9da884b9c08.1496237370.git.jthumshirn@suse.de>
As mentioned before I'd prefer a menaingful name that indicates the
purpose of the constant. In fact 4096 is a lot more obvious than SZ_4K,
and shortet as well :)
next prev parent reply other threads:[~2017-06-01 6:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 13:32 [PATCH v1 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-05-31 13:32 ` [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-01 6:33 ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 2/7] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-01 6:34 ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 3/7] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-01 6:42 ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 4/7] nvme: get list of namespace descriptors Johannes Thumshirn
2017-05-31 19:13 ` Max Gurtovoy
2017-06-01 6:49 ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 5/7] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-01 6:49 ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 6/7] nvme: change magic 4096 to SZ_4K Johannes Thumshirn
2017-06-01 6:50 ` Christoph Hellwig [this message]
2017-05-31 13:32 ` [PATCH v1 7/7] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-01 6:52 ` Christoph Hellwig
2017-06-01 6:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601065029.GF16778@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox