From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fix multiple ctrl removal scheduling
Date: Thu, 1 Jun 2017 17:41:07 +0200 [thread overview]
Message-ID: <20170601154107.GA8118@lst.de> (raw)
In-Reply-To: <3db3cb8f-0851-f114-2fc6-4710d5aab2db@grimberg.me>
On Thu, Jun 01, 2017@05:37:41PM +0300, Sagi Grimberg wrote:
> Did you catch my proposal to Keith and Rakesh?
I saw it.
>
> I proposed to synchronize with ctrl state NVME_CTRL_RESETTING
> before scheduling the reset_work and on removal flow (which is
> why the warning exist) simply do a sync cancel of reset_work.
>
> IMO, this is better than adding a new state to the ctrl state machine.
Why? Knowing from the state machine that we're going to reset
is very useful and will safe us from doing pointless work elsewhere.
There is a reason we have done it that way in Fabrics from the beginning.
E.g. as the work_busy check in nvme_should_reset can now be replaced
with a check for NVME_CTRL_SCHED_RESET and NVME_CTRL_RESETTING and
we're much more reliable.
next prev parent reply other threads:[~2017-06-01 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 14:06 respun multiple removal fix Christoph Hellwig
2017-06-01 14:06 ` [PATCH] nvme: fix multiple ctrl removal scheduling Christoph Hellwig
2017-06-01 14:37 ` Sagi Grimberg
2017-06-01 15:41 ` Christoph Hellwig [this message]
2017-06-01 22:02 ` Sagi Grimberg
2017-06-02 17:28 ` Rakesh Pandit
2017-06-03 7:31 ` Sagi Grimberg
2017-06-01 20:00 ` Keith Busch
2017-06-02 17:10 ` Rakesh Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601154107.GA8118@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox