From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: move protection information check into nvme_setup_rw
Date: Tue, 13 Jun 2017 10:03:00 +0200 [thread overview]
Message-ID: <20170613080300.GA611@lst.de> (raw)
In-Reply-To: <95127f6a-9e74-3c21-3d76-8b65dbb53288@suse.de>
On Tue, Jun 13, 2017@10:00:23AM +0200, Johannes Thumshirn wrote:
> > @@ -386,6 +395,7 @@ static inline void nvme_setup_rw(struct nvme_ns *ns, struct request *req,
> >
> > cmnd->rw.control = cpu_to_le16(control);
> > cmnd->rw.dsmgmt = cpu_to_le32(dsmgmt);
> > + return 0;
> > }
>
> And here you're returning 0 instead of BLK_STATUS_OK.
>
> Intentional?
Yes, at least sort of. Even for __bitwise types 0 is special, so
this is perfectly fine.
next prev parent reply other threads:[~2017-06-13 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 16:36 [PATCH] nvme: move protection information check into nvme_setup_rw Christoph Hellwig
2017-06-13 8:00 ` Johannes Thumshirn
2017-06-13 8:03 ` Christoph Hellwig [this message]
2017-06-13 14:55 ` Keith Busch
2017-06-15 9:21 ` Sagi Grimberg
2017-06-15 12:11 ` Christoph Hellwig
2017-06-15 12:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613080300.GA611@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox